[PATCH xserver] glx: Use __glXInitExtensionEnableBits in all backends (v2)

Jon Turney jon.turney at dronecode.org.uk
Wed Mar 30 17:48:46 UTC 2016


On 30/03/2016 16:06, Adam Jackson wrote:
> On xquartz this enables SGI_make_current_read, which is a mostly
> harmless lie as CGL doesn't implement it, as well as SGIX_pbuffer, which
> is fine because no pbuffer-enabled configs are created.
>
> On xwin this enables SGIX_pbuffer and ARB_multisample in all cases.
> Again this is harmless if the backend doesn't support the features,
> since no fbconfigs will be created to expose them.
>
> It also adds SGIX_visual_select_group to both xquartz and xwin.
> Amusingly, both were filling in the appropriate field in the fbconfig
> already.
>
> v2: Warn about missing WGL extensions (Emil)

Thanks for adding that.

Please apply the attached to fix compilation.

-------------- next part --------------
From 2457bf3695212c46ef494863fbf1c774b4da9573 Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney at dronecode.org.uk>
Date: Wed, 30 Mar 2016 18:31:38 +0100
Subject: [PATCH xserver] xwin/glx: Build fix for warnings about missing WGL
 extensioons

Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
---
 hw/xwin/glx/indirect.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/xwin/glx/indirect.c b/hw/xwin/glx/indirect.c
index 5d7ebf5..26832e6 100644
--- a/hw/xwin/glx/indirect.c
+++ b/hw/xwin/glx/indirect.c
@@ -634,7 +634,7 @@ glxWinScreenProbe(ScreenPtr pScreen)
         if (strstr(wgl_extensions, "WGL_ARB_make_current_read"))
             screen->has_WGL_ARB_make_current_read = TRUE;
         else
-            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_make_current_read\n")
+            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_make_current_read\n");
 
         if (strstr(gl_extensions, "GL_WIN_swap_hint")) {
             __glXEnableExtension(screen->base.glx_enable_bits,
@@ -659,12 +659,12 @@ glxWinScreenProbe(ScreenPtr pScreen)
         if (strstr(wgl_extensions, "WGL_ARB_pbuffer"))
             screen->has_WGL_ARB_pbuffer = TRUE;
         else
-            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_pbuffer\n")
+            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_pbuffer\n");
 
         if (strstr(wgl_extensions, "WGL_ARB_multisample"))
             screen->has_WGL_ARB_multisample = TRUE;
         else
-            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_multisample\n")
+            LogMessage(X_WARNING, "AIGLX: missing WGL_ARB_multisample\n");
 
         screen->base.destroy = glxWinScreenDestroy;
         screen->base.createContext = glxWinCreateContext;
-- 
2.7.4



More information about the xorg-devel mailing list