[PATCH xserver 00/13] GLX 1.4 cleanup and GLX_EXT_libglvnd

[Emil Velikov]

Hi Adam,

On 23 March 2016 at 22:46, Adam Jackson <ajax at redhat.com> wrote:
> The previous series didn't quite do what I expected, because xwin and
> xquartz didn't set the extension enable bits the same way as DRI. This
> series moves the enable bits into the common GLX screen data, fixes the
> default enable state to apply to all backends, and moves more of the
> setup boilerplate code into the core.
>
> The last patch finishes support for GLX_EXT_libglvnd by returning a
> vendor library string in glXQueryServerString. This is to enable libglvnd
> to select the correct implementation for applications that address multiple
> GL screens (or displays). At the moment this extension is only exposed for
> non-OSX and non-Windows builds, as libglvnd really isn't functional there.
> The swrast backend simply hardcodes the vendor to mesa. The DRI2 backend
> allows you to override the vendor string with Option "GlxVendorLibrary"
> in xorg.conf, in either the Device or Screen sections.
>
There's a few small suggestions - of which the "print a warning if the
WGL extension is missing" (patch 5&7) and Eric's "use strdup over
malloc/memset" (patch 13) being somewhat serious. With those addressed
the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Would be great to hear from Jon about patches 5 & 7 though. I suspect
that without the warnings he'll have lots of 'fun' moments debugging.

-Emil