[PATCH xserver] Switch to SW cursor right after HW cursor failure

[Michael Thayer]

Hello Alex,

On 18.03.2016 10:42, Alexandre Courbot wrote:
> Hello Michael,
>
> On 03/18/2016 06:09 PM, Michael Thayer wrote:
>> In that context, see this patch to Modesetting which I send a couple of
>> weeks ago, which should incidentally also fix your issue:
>>
>> https://patchwork.freedesktop.org/patch/75985/
>
> I applied your patch, but sadly it didn't fix my issue. I agree that
> your approach (actually returning drmmode_set_cursor() errors instead of
> relying on a side-effect) is better though. But it appears that I would
> need drmmode_show_cursor()'s errors to be reported for the same approach
> to work in my case.
>
> I see that the load_cursor_argb_check() hook has been added apparently
> to palliate the fact that load_cursor_argb() does not return an error
> status, would it be acceptable to apply the same principle to
> show_cursor()?

It certainly makes sense to me (noting that the *_check() hooks were 
Keith's idea).  Not sure off-hand how much you would have to change in 
the main X server code to make that work.

Regards,

Michael

>
> Thanks,
> Alex.

-- 
Michael Thayer | VirtualBox engineer
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher