[PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

Michel Dänzer michel at daenzer.net
Thu Mar 10 09:48:08 UTC 2016


On 10.03.2016 18:21, Martin Peres wrote:
> On 05/03/16 06:20, Michel Dänzer wrote:
>>
>>> I will provide an xtrace for this as soon as I can, but I wanted to
>>> provide you with a heads'up!
>>
>> FWIW, it'll be interesting to see the values of vblank->target_msc,
>> crtc_msc and ust in present_execute when it decides not to call
>> present_queue_vblank although vblank->requeue was set.
> 
> What would be the best way for me to trace that?

Something like this:

diff --git a/present/present.c b/present/present.c
index 1ce16af..62827b9 100644
--- a/present/present.c
+++ b/present/present.c
@@ -635,6 +635,9 @@ present_execute(present_vblank_ptr vblank, uint64_t ust, uint64_t crtc_msc)
                                             vblank->event_id,
                                             vblank->target_msc))
             return;
+        else
+            ErrorF("Not requeueing: vblank->target_msc=%lu crtc_msc=%lu ust=%lu\n",
+                   vblank->target_msc, crtc_msc, ust);
     }

     if (vblank->wait_fence) {


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list