[PATCH xserver v3] xwayland: add glamor Xv adaptor

[Adam Jackson]

On Tue, 2016-03-08 at 10:15 -0500, Olivier Fourdan wrote:
> Hi Adam,
> 
> I had posted a revisited version using GL_MAX_TEXTURE_SIZE to
> determine the encoder size as per your review last week, is there
> anything else that needs rework?

This adds a warning, but I don't think that's your fault:

xwayland-glamor-xv.c: In function ‘xwl_glamor_xv_add_adaptors’:
xwayland-glamor-xv.c:339:16: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     pa->type = XvWindowMask | XvInputMask | XvImageMask;;
                ^

% grep Xv.*put /usr/include/X11/extensions/*h
/usr/include/X11/extensions/Xv.h:#define XvInput          0
/usr/include/X11/extensions/Xv.h:#define XvOutput         1
/usr/include/X11/extensions/Xv.h:#define XvInputMask      (1L<<XvInput)
/usr/include/X11/extensions/Xv.h:#define XvOutputMask     (1L<<XvOutput)

I've sent a patch for videoproto, there's a few other instances of this.

It also doesn't link when building with --disable-xv:

  CCLD     Xwayland
xwayland-glamor-xv.c:382: error: undefined reference to 'XvFreeAdaptor'
xwayland-glamor-xv.c:328: error: undefined reference to 'XvScreenInit'
xwayland-glamor-xv.c:331: error: undefined reference to 'XvGetScreenKey'
xwayland-glamor-xv.c:252: error: undefined reference to 'XvGetRTPort'
xwayland-glamor-xv.c:367: error: undefined reference to 'XvFreeAdaptor'

glamor probably shouldn't build its xv support when --disable-xv,
either.

- ajax