[PATCH xserver 2/2] xwayland: add a server sync before repeating keys

[Daniel Stone]

Hi,

On 7 March 2016 at 17:45, Olivier Fourdan <ofourdan at redhat.com> wrote:
> Key repeat is handled by the X server, but input events need to be
> processed and forwarded by the Wayland compositor first.
>
> Make sure the Wayland compositor is actually processing events, to
> avoid repeating keys in xwayland while the Wayland compositor cannot
> deal with input events for whatever reason, thus not dispatching key
> release events, leading to fictious repeat keys while the use has
> already released the key.

I worry about the potential for deadlock here: what happens if the
compositor is blocked on a roundtrip to the X server (which can easily
happen with Mutter I believe), but the server processes the key repeat
timer before the client request? At that point, no-one can make
progress ...

Cheers,
Daniel