[PATCH xserver 0/9] double frees in AddResource failure paths

Rémi Cardona remi at gentoo.org
Mon Mar 7 23:30:10 UTC 2016


Le 07/03/2016 23:20, Julien Cristau a écrit :
> Hi,
> 
> prompted by Adam's recent fixes for unchecked AddResource, I've been
> looking at the failure paths, and found a number of places where it
> looks like we're freeing things twice (once as part of AddResource
> itself calling the destroy function for the resource, and once in the
> caller).  Plus more unchecked AddResource calls in xvmc and dri3.
> 
> Cheers,
> Julien

Caveat emptor: I didn't check that CreateNewResourceType was called with
a correct deleteFunc. With that said, the patches look correct to me:

Reviewed-by: Rémi Cardona <remi at gentoo.org>

Cheers


More information about the xorg-devel mailing list