[PATCH 1/2] present: fail flipping if we have any slave outputs.

[Keith Packard]

Dave Airlie <airlied at gmail.com> writes:

> Due to the way present currently works, we don't ever
> check with the secondary adapters if we can flip at all.
>
> We shouldn't flip if the secondary adapters are attached
> to the pixmap currently, however using the current check_flip
> callback isn't possible as it passes the Window to the driver
> (something we shouldn't be doing), so the slave driver can never
> get it's own screen ptr back.
>
> For now to fix the problem just block flips if we have any
> slaves configured. We can fix the ABI up later, but this
> fix can be backported to stable.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>

This doesn't obviously do this check when the output slave list is
modified, but looking at the code, it seems that
xf86RandR14ProviderSetOutputSource mashes the root clip a couple of
times to make sure the outputs all get repainted, and that should end up
calling ClipNotify on any flip window. So,

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160303/09cb9b94/attachment.sig>