[PATCH xserver 3/3] dri2: Don't make reference to noClientException

Adam Jackson ajax at redhat.com
Wed Jun 29 15:58:33 UTC 2016


On Tue, 2016-06-28 at 18:21 -0700, Keith Packard wrote:
> Adam Jackson <ajax at redhat.com> writes:
> 
> > noClientException is now never filled in with a meaningful value, it's
> > always -1. The sole caller of this function disregards the error value
> > in any case.
> 
> Sounds like we should just remove it from the client structure then?

The message here was unclear. The sole caller of __glXDRIcontextWait
ignores the error value, so it doesn't matter what we assign to *error
here.

noClientException is legitimately used by the dispatch loop for failure
conditions (failure to alloc a protocol output buffer eg). That could
probably be cleaned up further, sure.

- ajax


More information about the xorg-devel mailing list