[PATCH xserver] xkb: add a cause to the xkb indicator update after a keymap change

Julien Cristau jcristau at debian.org
Tue Jun 28 12:56:47 UTC 2016


On Tue, Jun 28, 2016 at 11:48:58 +1000, Peter Hutterer wrote:

> Regression introduce by ac164e58870d which calls
> XkbUpdateAllDeviceIndicators() with two NULL arguments. A few layers down into
> the stack and we triggered a NULL-pointer dereference. In theory a NULL cause
> is acceptable since we don't actually change modifier state here. Instead of
> updating all places to check for NULL just set the cause to the client
> request and go to the pub.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=96384
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  xkb/xkb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Going to the pub seems like a great plan.

Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien


More information about the xorg-devel mailing list