[PATCH xserver 1/2] modesetting: Fix swapping of provider sink / source capabilities

Emil Velikov emil.l.velikov at gmail.com
Wed Jun 22 19:19:43 UTC 2016


Hi Hans,

On 16 June 2016 at 14:37, Hans de Goede <hdegoede at redhat.com> wrote:
> When a card has import capability it can be an offload _sink_, not
> a source and vice versa for export capability.
>
> This commit fixes the modesetting driver to properly set these
> capabilities, this went unnoticed sofar because most gpus have both
> import and export capability.
>
Looking at randr/rrprovider.c ProcRRGetProviderInfo() and the
randrproto I'm not sure that this patch is correct.

"SourceOffload: This device can source offload buffers"

My understanding is that such device should have CAP_IMPORT since the
buffers will be sourced (imported) to the offload GPU to be processed.

Am I misunderstanding something ?

Thanks
Emil


More information about the xorg-devel mailing list