[PATCH xserver 2/3] xv: Remove some dumb calls SendErrorToClient

Adam Jackson ajax at redhat.com
Mon Jun 20 16:57:11 UTC 2016


We already generate errors from the top level when non-Success is
returned from a dispatch function, so really we were emitting errors
twice.

Signed-off-by: Adam Jackson <ajax at redhat.com>
---
 Xext/xvdisp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Xext/xvdisp.c b/Xext/xvdisp.c
index c2d0fc9..8a35b7b 100644
--- a/Xext/xvdisp.c
+++ b/Xext/xvdisp.c
@@ -949,7 +949,6 @@ ProcXvShmPutImage(ClientPtr client)
 static int
 ProcXvShmPutImage(ClientPtr client)
 {
-    SendErrorToClient(client, XvReqCode, xv_ShmPutImage, 0, BadImplementation);
     return BadImplementation;
 }
 #endif
@@ -1108,7 +1107,6 @@ ProcXvDispatch(ClientPtr client)
     UpdateCurrentTime();
 
     if (stuff->data >= xvNumRequests) {
-        SendErrorToClient(client, XvReqCode, stuff->data, 0, BadRequest);
         return BadRequest;
     }
 
@@ -1429,7 +1427,6 @@ SProcXvDispatch(ClientPtr client)
     UpdateCurrentTime();
 
     if (stuff->data >= xvNumRequests) {
-        SendErrorToClient(client, XvReqCode, stuff->data, 0, BadRequest);
         return BadRequest;
     }
 
-- 
2.7.4



More information about the xorg-devel mailing list