[PATCH RFC xserver] xwayland-input: Fake crossing to rootwin

Carlos Garnacho carlosg at gnome.org
Wed Jun 15 16:02:07 UTC 2016


Hey :),

On Wed, Jun 15, 2016 at 5:36 PM, Olivier Fourdan <ofourdan at redhat.com> wrote:
> Hi Carlos,
>
> ----- Original Message -----
>> Hey Olivier!,
>>
>> Without getting much into the patch (the rationale makes sense to me
>> though), restoring the XYToWindow handler probably means the patch at
>> https://patchwork.freedesktop.org/patch/50607/ should be reconsidered
>> again.
>
> Err, my memory doesn't serve me well here, can you remind me why we needed that patch again?
>
> Are we sure we still need this and how does it work without?
>
> Reason I'm asking is because my patch does not restore the XYToWindow() handler exactly as it was before (the removed version was causing more problem actually), now all it does it to return the root window when the focus_window is NULL, otherwise it calls back onto the original handler just as if the xwl_xy_to_window() wasn't there.

Oh, ok. Might not be needed then. The original patch was so window
lookup worked for individual touchpoints (which might happen in
different windows). IIRC the "pointer emulating" touch [1] would work
fine, but all other touchpoints wouldn't. I will try these with your
patch nonetheless, and send an updated patch if necessary.

Cheers,
  Carlos

[1] Not that there is such a thing in wayland, but the X server thinks there is.


More information about the xorg-devel mailing list