[PATCH libXfont] freetype: Fix a logic error in computing face name

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jun 8 22:02:53 UTC 2016


On 06/ 8/16 11:28 AM, Adam Jackson wrote:
> gcc6 chirps an indentation warning here, but really this is bad code.
> Effectively this would ignore en_US or en_UK names for the font, despite
> that those are the English names the font is most likely to have.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>   src/FreeType/fttools.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/FreeType/fttools.c b/src/FreeType/fttools.c
> index 7c0bd9b..0329fae 100644
> --- a/src/FreeType/fttools.c
> +++ b/src/FreeType/fttools.c
> @@ -100,7 +100,6 @@ FTGetName(FT_Face face, int nid, int pid, int eid, FT_SfntName *name_return)
>               case TT_PLATFORM_MICROSOFT:
>                   if(name.language_id != TT_MS_LANGID_ENGLISH_UNITED_STATES &&
>                      name.language_id != TT_MS_LANGID_ENGLISH_UNITED_KINGDOM)
> -                    break;
>                       continue;
>                   break;
>               default:
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list