[PATCH xserver 2/2] xwayland: Call eglBindAPI after eglInitialize
Pekka Paalanen
ppaalanen at gmail.com
Fri Jun 3 06:39:49 UTC 2016
On Fri, 3 Jun 2016 10:25:20 +0900
Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Current Mesa Git master checks that the EGL display actually supports
> the API passed to eglBindAPI, which can only succeed after
> eglInitialize.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
> ---
> hw/xwayland/xwayland-glamor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/xwayland/xwayland-glamor.c b/hw/xwayland/xwayland-glamor.c
> index ad66cf6..73ccd71 100644
> --- a/hw/xwayland/xwayland-glamor.c
> +++ b/hw/xwayland/xwayland-glamor.c
> @@ -298,12 +298,13 @@ xwl_drm_init_egl(struct xwl_screen *xwl_screen)
> return;
> }
>
> - eglBindAPI(EGL_OPENGL_API);
> if (!eglInitialize(xwl_screen->egl_display, &major, &minor)) {
> ErrorF("eglInitialize() failed\n");
> return;
> }
>
> + eglBindAPI(EGL_OPENGL_API);
> +
> version = eglQueryString(xwl_screen->egl_display, EGL_VERSION);
> ErrorF("glamor: EGL version %s:\n", version);
>
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
For this patch, and also for patch 1 though the context there is not
enough for me to see all the code between the removal and addition.
Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160603/50305ceb/attachment.sig>
More information about the xorg-devel
mailing list