[PATCH xserver] glamor: Cannot use copies when accessing outside of composite source

Hans de Goede hdegoede at redhat.com
Thu Jun 2 09:51:24 UTC 2016


Hi,

On 26-05-16 12:04, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> Commit b64108fa ("glamor: Check for composite operations which are
> equivalent to copies") failed to copy conditions from exaComposite which
> ensure that the composite operation doesn't access outside of the source
> picture.
>
> This fixes rendercheck regressions from the commit above.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

I know you've been discussing a different fix for this with Keith,
but I just noticed a regression rendering some web-pages in
firefox with current master, so I thought I would give this a try
and it indeed also fixes some real-world (vs rendercheck) issues.

If you want a real-world test point firefox to:

https://lkml.org/lkml/2015/8/25/738

At least that is broken for me (skylake igpu + modesetting driver)
and this patch fixes it.

Regards,

Hans


More information about the xorg-devel mailing list