[PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v5

Michel Dänzer michel at daenzer.net
Wed Jul 27 09:06:52 UTC 2016


On 27.07.2016 00:55, Keith Packard wrote:
> Michel Dänzer <michel at daenzer.net> writes:
> 
>> +    if (randrp->palette_size != palette_size) {
>> +        randrp->palette = reallocarray(randrp->palette, palette_size,
>> +                                       sizeof(colors[0]));
> 
> Need error checking here.

Fixed in v6.


> Wow. Otherwise, this patch looks great to me. Thanks for fixing a
> long-standing limitation in the server.

Thanks for the review feedback.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160727/90e80d3e/attachment.sig>


More information about the xorg-devel mailing list