[PATCH xserver 3/3] xfree86: Hook up colormaps and RandR 1.2 gamma code v5
Michel Dänzer
michel at daenzer.net
Tue Jul 26 09:12:14 UTC 2016
From: Michel Dänzer <michel.daenzer at amd.com>
Instead of breaking the former when the driver supports the latter,
hook them up so that the hardware LUTs reflect the combination of the
current colourmap and gamma states. I.e. combine the colourmap, the
global gamma value/ramp and the RandR 1.2 per-CRTC gamma ramps into one
combined LUT per CRTC.
Fixes e.g. gamma sliders not working in games.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=27222
v2:
* Initialize palette_size and palette struct members, fixes crash on
server startup.
v3:
* Free randrp->palette in xf86RandR12CloseScreen, fixes memory leak.
v4:
* Call CMapUnwrapScreen if xf86RandR12InitGamma fails (Emil Velikov).
* Still allow xf86HandleColormaps to be called with a NULL loadPalette
parameter in the xf86_crtc_supports_gamma case.
v5:
* Clean up inner loops in xf86RandR12CrtcComputeGamma (Keith Packard)
* Move palette update out of per-CRTC loop in xf86RandR12LoadPalette
(Keith Packard)
Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---
hw/xfree86/common/xf86Helper.c | 7 +-
hw/xfree86/common/xf86cmap.c | 60 +++------------
hw/xfree86/modes/xf86RandR12.c | 171 ++++++++++++++++++++++++-----------------
hw/xfree86/modes/xf86RandR12.h | 5 ++
4 files changed, 120 insertions(+), 123 deletions(-)
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index bceb017..6f3a608 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/xf86Helper.c
@@ -54,7 +54,6 @@
#include "xf86Xinput.h"
#include "xf86InPriv.h"
#include "mivalidate.h"
-#include "xf86Crtc.h"
/* For xf86GetClocks */
#if defined(CSRG_BASED) || defined(__GNU__)
@@ -908,11 +907,7 @@ xf86SetGamma(ScrnInfoPtr scrp, Gamma gamma)
scrp->gamma.green = 1.0;
scrp->gamma.blue = 1.0;
}
- /* Pretend we succeeded if we support better a gamma system.
- * This avoids a confusing message.
- */
- if (xf86_crtc_supports_gamma(scrp))
- return TRUE;
+
xf86DrvMsg(scrp->scrnIndex, from,
"Using gamma correction (%.1f, %.1f, %.1f)\n",
scrp->gamma.red, scrp->gamma.green, scrp->gamma.blue);
diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c
index ba0b277..8588c9f 100644
--- a/hw/xfree86/common/xf86cmap.c
+++ b/hw/xfree86/common/xf86cmap.c
@@ -49,6 +49,7 @@
#include "xf86_OSproc.h"
#include "xf86str.h"
#include "micmap.h"
+#include "xf86RandR12.h"
#include "xf86Crtc.h"
#ifdef XFreeXDGA
@@ -132,9 +133,6 @@ static void CMapUnwrapScreen(ScreenPtr pScreen);
Bool
xf86ColormapAllocatePrivates(ScrnInfoPtr pScrn)
{
- /* If we support a better colormap system, then pretend we succeeded. */
- if (xf86_crtc_supports_gamma(pScrn))
- return TRUE;
if (!dixRegisterPrivateKey(&CMapScreenKeyRec, PRIVATE_SCREEN, 0))
return FALSE;
@@ -157,11 +155,8 @@ xf86HandleColormaps(ScreenPtr pScreen,
int *indices;
int elements;
- /* If we support a better colormap system, then pretend we succeeded. */
- if (xf86_crtc_supports_gamma(pScrn))
- return TRUE;
-
- if (!maxColors || !sigRGBbits || !loadPalette)
+ if (!maxColors || !sigRGBbits ||
+ (!loadPalette && !xf86_crtc_supports_gamma(pScrn)))
return FALSE;
elements = 1 << sigRGBbits;
@@ -230,6 +225,15 @@ xf86HandleColormaps(ScreenPtr pScreen,
return FALSE;
}
+ if (xf86_crtc_supports_gamma(pScrn)) {
+ pScrn->LoadPalette = xf86RandR12LoadPalette;
+
+ if (!xf86RandR12InitGamma(pScrn, elements)) {
+ CMapUnwrapScreen(pScreen);
+ return FALSE;
+ }
+ }
+
/* Force the initial map to be loaded */
SetInstalledmiColormap(pScreen, NULL);
CMapInstallColormap(pDefMap);
@@ -1005,19 +1009,6 @@ xf86ChangeGammaRamp(ScreenPtr pScreen,
CMapScreenPtr pScreenPriv;
CMapLinkPtr pLink;
- if (xf86_crtc_supports_gamma(pScrn)) {
- RRCrtcPtr crtc = xf86CompatRRCrtc(pScrn);
-
- if (crtc) {
- if (crtc->gammaSize != size)
- return BadValue;
-
- RRCrtcGammaSet(crtc, red, green, blue);
-
- return Success;
- }
- }
-
if (!CMapScreenKeyRegistered)
return BadImplementation;
@@ -1077,16 +1068,8 @@ xf86ChangeGammaRamp(ScreenPtr pScreen,
int
xf86GetGammaRampSize(ScreenPtr pScreen)
{
- ScrnInfoPtr pScrn = xf86ScreenToScrn(pScreen);
CMapScreenPtr pScreenPriv;
- if (xf86_crtc_supports_gamma(pScrn)) {
- RRCrtcPtr crtc = xf86CompatRRCrtc(pScrn);
-
- if (crtc)
- return crtc->gammaSize;
- }
-
if (!CMapScreenKeyRegistered)
return 0;
@@ -1104,29 +1087,10 @@ xf86GetGammaRamp(ScreenPtr pScreen,
unsigned short *red,
unsigned short *green, unsigned short *blue)
{
- ScrnInfoPtr pScrn = xf86ScreenToScrn(pScreen);
CMapScreenPtr pScreenPriv;
LOCO *entry;
int shift, sigbits;
- if (xf86_crtc_supports_gamma(pScrn)) {
- RRCrtcPtr crtc = xf86CompatRRCrtc(pScrn);
-
- if (crtc) {
- if (crtc->gammaSize < size)
- return BadValue;
-
- if (!RRCrtcGammaGet(crtc))
- return BadImplementation;
-
- memcpy(red, crtc->gammaRed, size * sizeof(*red));
- memcpy(green, crtc->gammaGreen, size * sizeof(*green));
- memcpy(blue, crtc->gammaBlue, size * sizeof(*blue));
-
- return Success;
- }
- }
-
if (!CMapScreenKeyRegistered)
return BadImplementation;
diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw/xfree86/modes/xf86RandR12.c
index e097fa7..8c80f19 100644
--- a/hw/xfree86/modes/xf86RandR12.c
+++ b/hw/xfree86/modes/xf86RandR12.c
@@ -40,6 +40,7 @@
#include <randrstr.h>
#include <X11/extensions/render.h>
+#include "xf86cmap.h"
#include "xf86Crtc.h"
#include "xf86RandR12.h"
@@ -55,6 +56,13 @@ typedef struct _xf86RandR12Info {
Rotation rotation; /* current mode */
Rotation supported_rotations; /* driver supported */
+ /* Compatibility with colormaps and XF86VidMode's gamma */
+ int palette_red_size;
+ int palette_green_size;
+ int palette_blue_size;
+ int palette_size;
+ LOCO *palette;
+
/* Used to wrap EnterVT so we can re-probe the outputs when a laptop unsuspends
* (actually, any time that we switch back into our VT).
*
@@ -882,6 +890,9 @@ xf86RandR12Init(ScreenPtr pScreen)
randrp->maxX = randrp->maxY = 0;
+ randrp->palette_size = 0;
+ randrp->palette = NULL;
+
dixSetPrivate(&pScreen->devPrivates, xf86RandR12Key, randrp);
#if RANDR_12_INTERFACE
@@ -905,6 +916,7 @@ xf86RandR12CloseScreen(ScreenPtr pScreen)
pScreen->ConstrainCursorHarder = randrp->orig_ConstrainCursorHarder;
#endif
+ free(randrp->palette);
free(randrp);
}
@@ -1237,37 +1249,47 @@ xf86RandR12CrtcSet(ScreenPtr pScreen,
return xf86RandR12CrtcNotify(randr_crtc);
}
-static Bool
-xf86RandR12CrtcSetGamma(ScreenPtr pScreen, RRCrtcPtr randr_crtc)
+static void
+xf86RandR12CrtcComputeGamma(ScreenPtr pScreen, RRCrtcPtr randr_crtc)
{
+ XF86RandRInfoPtr randrp = XF86RANDRINFO(pScreen);
xf86CrtcPtr crtc = randr_crtc->devPrivate;
+ int gamma_slots;
+ CARD16 value;
+ int i, j;
- if (crtc->funcs->gamma_set == NULL)
- return FALSE;
+ gamma_slots = crtc->gamma_size / randrp->palette_red_size;
+ for (i = 0; i < randrp->palette_red_size; i++) {
+ value = randr_crtc->gammaRed[randrp->palette[i].red];
- if (!crtc->scrn->vtSema)
- return TRUE;
+ for (j = 0; j < gamma_slots; j++)
+ crtc->gamma_red[i * gamma_slots + j] = value;
+ }
- /* Realloc local gamma if needed. */
- if (randr_crtc->gammaSize != crtc->gamma_size) {
- CARD16 *tmp_ptr;
+ gamma_slots = crtc->gamma_size / randrp->palette_green_size;
+ for (i = 0; i < randrp->palette_green_size; i++) {
+ value = randr_crtc->gammaGreen[randrp->palette[i].green];
- tmp_ptr = reallocarray(crtc->gamma_red,
- randr_crtc->gammaSize, 3 * sizeof(CARD16));
- if (!tmp_ptr)
- return FALSE;
- crtc->gamma_red = tmp_ptr;
- crtc->gamma_green = crtc->gamma_red + randr_crtc->gammaSize;
- crtc->gamma_blue = crtc->gamma_green + randr_crtc->gammaSize;
+ for (j = 0; j < gamma_slots; j++)
+ crtc->gamma_green[i * gamma_slots + j] = value;
+ }
+
+ gamma_slots = crtc->gamma_size / randrp->palette_blue_size;
+ for (i = 0; i < randrp->palette_blue_size; i++) {
+ value = randr_crtc->gammaBlue[randrp->palette[i].blue];
+
+ for (j = 0; j < gamma_slots; j++)
+ crtc->gamma_blue[i * gamma_slots + j] = value;
}
+}
+
+static void
+xf86RandR12CrtcReloadGamma(RRCrtcPtr randr_crtc)
+{
+ xf86CrtcPtr crtc = randr_crtc->devPrivate;
- crtc->gamma_size = randr_crtc->gammaSize;
- memcpy(crtc->gamma_red, randr_crtc->gammaRed,
- crtc->gamma_size * sizeof(CARD16));
- memcpy(crtc->gamma_green, randr_crtc->gammaGreen,
- crtc->gamma_size * sizeof(CARD16));
- memcpy(crtc->gamma_blue, randr_crtc->gammaBlue,
- crtc->gamma_size * sizeof(CARD16));
+ if (!crtc->scrn->vtSema || !crtc->funcs->gamma_set)
+ return;
/* Only set it when the crtc is actually running.
* Otherwise it will be set when it's activated.
@@ -1275,6 +1297,21 @@ xf86RandR12CrtcSetGamma(ScreenPtr pScreen, RRCrtcPtr randr_crtc)
if (crtc->active)
crtc->funcs->gamma_set(crtc, crtc->gamma_red, crtc->gamma_green,
crtc->gamma_blue, crtc->gamma_size);
+}
+
+static Bool
+xf86RandR12CrtcSetGamma(ScreenPtr pScreen, RRCrtcPtr randr_crtc)
+{
+ XF86RandRInfoPtr randrp = XF86RANDRINFO(pScreen);
+ xf86CrtcPtr crtc = randr_crtc->devPrivate;
+
+ if (crtc->funcs->gamma_set == NULL)
+ return FALSE;
+
+ if (randrp->palette_size) {
+ xf86RandR12CrtcComputeGamma(pScreen, randr_crtc);
+ xf86RandR12CrtcReloadGamma(randr_crtc);
+ }
return TRUE;
}
@@ -1358,7 +1395,7 @@ xf86RandR12OutputInitGamma(xf86OutputPtr output)
return TRUE;
}
-static Bool
+Bool
xf86RandR12InitGamma(ScrnInfoPtr pScrn, unsigned gammaSize) {
xf86CrtcConfigPtr config = XF86_CRTC_CONFIG_PTR(pScrn);
int o, c;
@@ -1815,57 +1852,54 @@ xf86RandR13SetPanning(ScreenPtr pScreen,
}
/*
- * Compatibility with XF86VidMode's gamma changer. This necessarily clobbers
- * any per-crtc setup. You asked for it...
+ * Compatibility with colormaps and XF86VidMode's gamma
*/
-
-static void
-gamma_to_ramp(float gamma, CARD16 *ramp, int size)
+void
+xf86RandR12LoadPalette(ScrnInfoPtr pScrn, int numColors, int *indices,
+ LOCO *colors, VisualPtr pVisual)
{
- int i;
+ ScreenPtr pScreen = pScrn->pScreen;
+ XF86RandRInfoPtr randrp = XF86RANDRINFO(pScreen);
+ xf86CrtcConfigPtr config = XF86_CRTC_CONFIG_PTR(pScrn);
+ int reds, greens, blues, index, palette_size;
+ int c, i;
- for (i = 0; i < size; i++) {
- if (gamma == 1.0)
- ramp[i] = i | i << 8;
- else
- ramp[i] =
- (CARD16) (pow((double) i / (double) (size - 1), 1. / gamma)
- * (double) (size - 1) * 257);
+ if (pVisual->class == TrueColor || pVisual->class == DirectColor) {
+ reds = (pVisual->redMask >> pVisual->offsetRed) + 1;
+ greens = (pVisual->greenMask >> pVisual->offsetGreen) + 1;
+ blues = (pVisual->blueMask >> pVisual->offsetBlue) + 1;
+ } else {
+ reds = greens = blues = pVisual->ColormapEntries;
}
-}
-
-static int
-xf86RandR12ChangeGamma(ScrnInfoPtr pScrn, Gamma gamma)
-{
- CARD16 *points, *red, *green, *blue;
- RRCrtcPtr crtc = xf86CompatRRCrtc(pScrn);
- int size;
-
- if (!crtc)
- return Success;
- size = max(0, crtc->gammaSize);
- if (!size)
- return Success;
+ palette_size = max(reds, max(greens, blues));
- points = calloc(size, 3 * sizeof(CARD16));
- if (!points)
- return BadAlloc;
-
- red = points;
- green = points + size;
- blue = points + 2 * size;
-
- gamma_to_ramp(gamma.red, red, size);
- gamma_to_ramp(gamma.green, green, size);
- gamma_to_ramp(gamma.blue, blue, size);
- RRCrtcGammaSet(crtc, red, green, blue);
-
- free(points);
+ if (randrp->palette_size != palette_size) {
+ randrp->palette = reallocarray(randrp->palette, palette_size,
+ sizeof(colors[0]));
+ randrp->palette_size = palette_size;
+ }
+ randrp->palette_red_size = reds;
+ randrp->palette_green_size = greens;
+ randrp->palette_blue_size = blues;
+
+ for (i = 0; i < numColors; i++) {
+ index = indices[i];
+
+ if (index < reds)
+ randrp->palette[index].red = colors[index].red;
+ if (index < greens)
+ randrp->palette[index].green = colors[index].green;
+ if (index < blues)
+ randrp->palette[index].blue = colors[index].blue;
+ }
- pScrn->gamma = gamma;
+ for (c = 0; c < config->num_crtc; c++) {
+ RRCrtcPtr randr_crtc = config->crtc[c]->randr_crtc;
- return Success;
+ xf86RandR12CrtcComputeGamma(pScreen, randr_crtc);
+ xf86RandR12CrtcReloadGamma(randr_crtc);
+ }
}
static Bool
@@ -1888,7 +1922,7 @@ xf86RandR12EnterVT(ScrnInfoPtr pScrn)
/* reload gamma */
for (i = 0; i < rp->numCrtcs; i++)
- xf86RandR12CrtcSetGamma(pScreen, rp->crtcs[i]);
+ xf86RandR12CrtcReloadGamma(rp->crtcs[i]);
return RRGetInfo(pScreen, TRUE); /* force a re-probe of outputs and notify clients about changes */
}
@@ -2067,7 +2101,6 @@ xf86RandR12Init12(ScreenPtr pScreen)
rp->rrProviderDestroy = xf86RandR14ProviderDestroy;
pScrn->PointerMoved = xf86RandR12PointerMoved;
- pScrn->ChangeGamma = xf86RandR12ChangeGamma;
randrp->orig_EnterVT = pScrn->EnterVT;
pScrn->EnterVT = xf86RandR12EnterVT;
diff --git a/hw/xfree86/modes/xf86RandR12.h b/hw/xfree86/modes/xf86RandR12.h
index e603799..31aaaaf 100644
--- a/hw/xfree86/modes/xf86RandR12.h
+++ b/hw/xfree86/modes/xf86RandR12.h
@@ -40,4 +40,9 @@ extern _X_EXPORT void xf86RandR12GetOriginalVirtualSize(ScrnInfoPtr pScrn,
extern _X_EXPORT Bool xf86RandR12PreInit(ScrnInfoPtr pScrn);
extern _X_EXPORT void xf86RandR12TellChanged(ScreenPtr pScreen);
+extern void xf86RandR12LoadPalette(ScrnInfoPtr pScrn, int numColors,
+ int *indices, LOCO *colors,
+ VisualPtr pVisual);
+extern Bool xf86RandR12InitGamma(ScrnInfoPtr pScrn, unsigned gammaSize);
+
#endif /* _XF86_RANDR_H_ */
--
2.8.1
More information about the xorg-devel
mailing list