[PATCH xserver 1/2] glamor: Fix copy-like Render operations between 15 and 16 depth.

Keith Packard keithp at keithp.com
Thu Jan 21 19:46:53 PST 2016


Eric Anholt <eric at anholt.net> writes:

>      if (op == PictOpSrc) {
> +        /* We can't do direct copies between different depths at 16bpp
> +         * because r,g,b are allocated to different bits.
> +         */
> +        if (dst->pDrawable->bitsPerPixel == 16 &&
> +            dst->pDrawable->depth != src->pDrawable->depth) {
> +            return 0;
> +        }
> +

How can this pass the following check then? The render format is
supposed to completely define the component layout within a pixel?

>          if (src->format == dst->format)
>              return 1;

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20160121/39b42490/attachment.sig>


More information about the xorg-devel mailing list