[PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

[Ilia Mirkin]

On Wed, Jan 20, 2016 at 2:47 PM, Adam Jackson <ajax at nwnk.net> wrote:
> On Tue, 2016-01-19 at 10:06 -0500, Ilia Mirkin wrote:
>> dEQP tests request a specific version. The EXT spec has been updated to
>> allow other versions, so allow anything >= 2.0 to be requested.
>
> (Comic book guy voice) Actually...
>
>>      case GLX_CONTEXT_ES2_PROFILE_BIT_EXT:
>
> The spec says:
>
>>     Accepted as a bit in the attribute value for
>>     GLX_CONTEXT_PROFILE_MASK_ARB in <*attrib_list>:
>>
>>       GLX_CONTEXT_ES_PROFILE_BIT_EXT          0x00000004
>>       GLX_CONTEXT_ES2_PROFILE_BIT_EXT         0x00000004
>
> And that, strictly speaking, we should be exposing both the
> _es2_profile and _es_profile strings.  So I think this is only correct
> if no Mesa driver could create an ES1 profile, and I'm pretty sure
> that's not the case.

Yeah, they changed it so that they're the same, and can optionally
return ES1 contexts. However I don't think anything is wired up for
GLX and ES1, so I wanted to leave that alone for now.

That said, if you believe the only thing that needs to be done to (on
the X server side) support ES1 with GLX is to remove that return, more
than happy to send another patch that always lets it succeed.

  -ilia