[PATCH xserver 0/9] Rewrite root window property setup

Adam Jackson ajax at redhat.com
Wed Jan 6 06:30:28 PST 2016


Leo's patch to fix the EDID atom leak is probably correct, in the sense that
it fixes the leak, but xf86RegisterRootWindowProperty is fairly ugly to
begin with so I'd rather see it eliminated.  This series adds a generic
callback for screen finalization and ports xfree86 to it.  Since
dixChangeWindowProperty will copy the property data for us this should fix
the leak as well, since we're not making a copy for xf86CreateRootWindow
anymore.

While I was at it I cleaned up some pointless API, and fixed a bug that
prevented the EDID property being updated on hotplug events.

Disclaimer: just compiled, not actually tested yet.

 dix/main.c                      |   3 +
 hw/xfree86/common/xf86.h        |   9 ---
 hw/xfree86/common/xf86Globals.c |   1 -
 hw/xfree86/common/xf86Helper.c  |  81 --------------------
 hw/xfree86/common/xf86Init.c    | 158 ++++++++++++----------------------------
 hw/xfree86/common/xf86Priv.h    |   4 +-
 hw/xfree86/common/xf86Privstr.h |  10 ---
 hw/xfree86/ddc/ddcProperty.c    |  56 +++++++-------
 hw/xfree86/ddc/edid.h           |   1 -
 hw/xfree86/doc/ddxDesign.xml    |  12 ---
 include/dix.h                   |   2 +
 11 files changed, 77 insertions(+), 260 deletions(-)

- ajax



More information about the xorg-devel mailing list