[PATCH kdrive/ephyr v7 3/9] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 11 16:51:49 UTC 2016


On 10 February 2016 at 18:57, LaƩrcio de Sousa
<laerciosousa at sme-mogidascruzes.sp.gov.br> wrote:
> 2016-02-08 17:45 GMT-02:00 Adam Jackson <ajax at nwnk.net>:
>>
>> This introduces a warning:
>>
>> kdrive.c:1217:1: warning: no previous prototype for
>> 'systemd_logind_release_fd' [-Wmissing-prototypes]
>>  systemd_logind_release_fd(int _major, int _minor, int fd)
>>  ^
>> kdrive.c:1222:1: warning: no previous prototype for
>> 'systemd_logind_vtenter' [-Wmissing-prototypes]
>>  systemd_logind_vtenter(void)
>>
>>  ^
>
> OK. I've just introduced the prototypes in kdrive.c itself (so I don't need
> to #include <systemd-logind.h>). These warnings are now gone.
>
Please don't add yet more declarations, when ones are available.

The header contains a nice set of macros which expand nicely in case
of missing systemd. Plus it is self-contained so it doesn't pull any
requirements.

Thanks
Emil


More information about the xorg-devel mailing list