Xorg glx module: GLVND, EGL, or ... ?

[Yu, Qiang]

More clearly I think it will be good to have an environment variable in GLVND
can specify the EGL vendor driver try order like:
GLVND_EGL_VENDOR_ORDER=amdgpu-pro:mesa

So amdgpu-pro vendor driver is tried first and return fail on non-amd GPUs
and no need an environment variable in both mesa and amdgpu-pro.

Regards,
Qiang
________________________________________
From: Yu, Qiang
Sent: Wednesday, December 28, 2016 2:43:38 PM
To: Kyle Brenneman; Adam Jackson; Emil Velikov; Michel Dänzer
Cc: ML xorg-devel
Subject: Re: Xorg glx module: GLVND, EGL, or ... ?

For EGL, when the app calls eglGetPlatformDisplay or
eglGetDisplay(EGL_DEFAULT_DISPLAY), then libglvnd will just try each
driver in the order they're listed until it finds one that works. You
could select between two drivers based on an environment variable like
DRI_PRIME just by having one driver or the other succeed.

[yuq] You mean if both vendor driver work for a call, the first success one will
be chosen, and an environment variable in first vendor driver can be used to
choose return fail if it is not what we want? If work like this, can we
specify the driver list order? Because vendor can only change its own driver
to add this environment variable. Otherwise we need to add this env to mesa.

Regards,
Qiang

On 12/27/2016 08:26 PM, Yu, Qiang wrote:
> So use like this per application?
> DRI_PRIME=1 __GLX_VENDOR_LIBRARY_NAME=xxx glxgears
> DRI_PRIME=1 EGL_PLATFORM=xxx es2gears
>
> Another problem is if two EGL vendor can both be used, how do I
> select which to use within one application? For example, in xserver,
> load two DDX for two GPU: modesetting DDX use mesa EGL,
> amdgpu DDX use amdgpu-pro EGL (it can use mesa too).
> The interface is the same (both is initialized from gbm fd).
> Which is the default one?
>
> Will this work? In amdgpu DDX code temporarily set EGL_PLATFORM=amdgpu-pro
> when init, unset when init is done.
>
> Regards,
> Qiang
> ________________________________________
> From: Kyle Brenneman <kbrenneman at nvidia.com>
> Sent: Wednesday, December 28, 2016 10:18:13 AM
> To: Yu, Qiang; Adam Jackson; Emil Velikov; Michel Dänzer
> Cc: ML xorg-devel
> Subject: Re: Xorg glx module: GLVND, EGL, or ... ?
>
> GLVND doesn't respond to DRI_PRIME (and probably shouldn't, since that's
> very driver-specific), but it has an environment variable that you can
> use to override which vendor library it selects.
>
> That's entirely on the client side, so whatever driver to tell it to use
> still needs to be able to talk to the server.
>
> -Kyle
>
> On 12/27/2016 07:06 PM, Yu, Qiang wrote:
>> Yes, mesa can handle DRI_PRIME alone. But my use case is:
>> 1. PRIME GPU (iGPU) use mesa libGL
>> 2. Secondary GPU (dGPU) use close source libGL
>>
>> If this can be done, we can use dynamic GPU offload in hybrid GPU platforms,
>> currently we have to switch between GPUs statically (change xorg.conf).
>>
>> When DRI2, secondary GPU has a GPUScreen on the xserver side which can
>> be used to obtain vendor info (although not implemented). But DRI3, client
>> just do offload when DRI_PRIME=1 is set without inform xserver.
>>
>> The only method I can think of is using a config file for GLVND which records the
>> secondary GPU's vendor to use when DRI_PRIME is set like:
>> <pci id> <vendor>
>>
>> What's your opinion?
>>
>> Regards,
>> Qiang
>> ________________________________________
>> From: Kyle Brenneman <kbrenneman at nvidia.com>
>> Sent: Wednesday, December 28, 2016 1:05:50 AM
>> To: Yu, Qiang; Adam Jackson; Emil Velikov; Michel Dänzer
>> Cc: ML xorg-devel
>> Subject: Re: Xorg glx module: GLVND, EGL, or ... ?
>>
>> Is DRI_PRIME handled within the Mesa?
>>
>> If so, then no support from GLVND is needed. The GLVND libraries would
>> simply dispatch any function calls to Mesa, which in turn would handle
>> those calls the same way it would in a non-GLVND system.
>>
>> -Kyle
>>
>> On 12/23/2016 07:31 PM, Yu, Qiang wrote:
>>> Hi guys,
>>>
>>> Does GLVND support DRI_PRIME=1? If the secondary GPU uses different
>>> libGL than primary GPU, how GLVND get the vendor to use?
>>>
>>> Regards,
>>> Qiang
>>> ________________________________________
>>> From: Adam Jackson <ajax at redhat.com>
>>> Sent: Saturday, December 17, 2016 6:02:18 AM
>>> To: Emil Velikov; Michel Dänzer
>>> Cc: Kyle Brenneman; Yu, Qiang; ML xorg-devel
>>> Subject: Re: Xorg glx module: GLVND, EGL, or ... ?
>>>
>>> On Thu, 2016-12-15 at 16:08 +0000, Emil Velikov wrote:
>>>
>>>> Example:
>>>> Would happen if we one calls glXMakeCurrent which internally goes down
>>>> to eglMakeCurrent ? Are we going to clash since (iirc) one is not
>>>> allowed to do both on the same GL ctx ?
>>> No, for the same reason this already isn't a problem. If you
>>> glXMakeCurrent an indirect context, the X server does not itself call
>>> glXMakeCurrent. All it does is record the client's binding. Only when
>>> we go do to actual indirect rendering (or mutate context state) does
>>> libglx actually make that context "current". That context is a tuple of
>>> the protocol state and a DRI driver context; it could just as easily be
>>> an EGL context instead of DRI.
>>>
>>> - ajax