[Spice-devel] [qxl] xspice: Adjust to X.org 1.19 changes

[Christophe Fergeau]

On Thu, Dec 15, 2016 at 02:01:03PM +0200, Uri Lublin wrote:
> Hi Christophe,
> 
> Please see some comments below
> 
> On 12/14/2016 12:51 PM, Christophe Fergeau wrote:
> > +static int watch_update_mask2(SpiceWatch *watch, int event_mask)
> > +{
> > +    SetNotifyFd(watch->fd, NULL, X_NOTIFY_NONE, NULL);
> > +    watch->event_mask = 0;
> > +
> > +    if (event_mask & SPICE_WATCH_EVENT_READ) {
> > +        SetNotifyFd(watch->fd, watch_fd_notified, X_NOTIFY_READ, watch);
> > +    } else if (event_mask & SPICE_WATCH_EVENT_READ) {
> 
> 1. This should be (event_mask & SPICE_WATCH_EVENT_WRITE)

Oops, good catch!

> 2. The "else if" fails to support event_mask which is READ | WRITE.
>    Can it not watch both events ?

For some reason, I think I decided this was not needed, but I can't see
why now. I'll update the code.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20161215/e8005470/attachment.sig>