[PATCH xserver v2 0/5] Allow XWM to control Xwayland commits

Pekka Paalanen ppaalanen at gmail.com
Fri Dec 9 12:24:11 UTC 2016

From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


this is v2 of _XWAYLAND_ALLOW_COMMITS property support in Xwayland to allow the
window manager to control when wl_surface.commits occur. The first revision was
posted here:

The fundamental problem is that Xwayland and the Wayland compositor (window
manager) are racing, particularly when windows are being mapped. This can lead
to glitches. The specific glitch I bumped into is described at
https://phabricator.freedesktop.org/T7622 .

The proposed solution allows the WM to temporarily prohibit commits.

In this v2 series:
- patches 1 and 2 are new and needed to stop using XACE hooks
- patches 3 and 4 are the same as v1, R-b Olivier
- patch 5 changes are listed in the commit message

The v2 series is also available as a branch:

This patch series is the Xwayland side of the fix to T7622. The Weston series
is here:


Adam Jackson (2):
  dix: Pass the whole property into deliverPropertyNotifyEvent
  dix: Add a callback chain for window property state change

Pekka Paalanen (3):
  xwayland: refactor into xwl_window_post_damage()
  xwayland: fix 'buffer' may be used uninitialized warning
  xwayland: use _XWAYLAND_ALLOW_COMMITS property

 dix/property.c         |  23 +++++--
 hw/xwayland/xwayland.c | 170 ++++++++++++++++++++++++++++++++++++++++++-------
 hw/xwayland/xwayland.h |   3 +
 include/property.h     |   8 +++
 4 files changed, 174 insertions(+), 30 deletions(-)


More information about the xorg-devel mailing list