[PATCH v2 xserver 1/2] glamor: Add glamor_shareable_fd_from_pixmap()

Hans de Goede hdegoede at redhat.com
Thu Aug 25 09:24:05 UTC 2016


Hi,

On 24-08-16 20:48, Keith Packard wrote:
> Hans de Goede <hdegoede at redhat.com> writes:
>
>> Add glamor_shareable_fd_from_pixmap function to get dma-buf fds suitable
>> for sharing across GPUs (not using GPU specific tiling).
>>
>> This is necessary for the modesetting driver to correctly implement
>> the DRI2 SharePixmapBacking callback.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> For the series:
>
> Reviewed-by: Keith Packard <keithp at keithp.com>

Thanks.

It would also be great to get your input on my reply to
Airlied's "modesetting: prefer primary crtc when picking over nothing"
and/or my series starting with:
"modesetting: ms_covering_crtc: Remove unused arguments, make static"
which solves the same problem, but then only for showing DRI3
buffers on slave-outputs (which currently gets throttled
to 1 fps with the modesetting driver though).

I've a slight preference for Airlied's fix actually since
all 3 major drivers (intel, nouveau, ati) seem to do the
same so chances are that epiphany is not the only driver
depending on this.

Regards,

Hans

p.s.

About my series for the throttling on slave output's
I'm working on a v2 which will not fallback to the
primary crtc if that is DPMSOff, but the basic principle
will be unchanged.




More information about the xorg-devel mailing list