[PATCH xserver] modesetting: Fix msSharePixmapBacking returning a non-linear bo

Keith Packard keithp at keithp.com
Thu Aug 18 16:21:35 UTC 2016


Hans de Goede <hdegoede at redhat.com> writes:

> An alternative solution would be to add a flag argument to
> glamor_fd_from_pixmap, so that callers like this one which
> know for sure they want a linear bo can specify that through
> a flag, and other callers can just pass in:

fd_from_pixmap is the API exposed for DRI3 to move pixmaps between
applications and the server. Using this for driver to driver sharing
seems like a stretch to me, so instead of adding an argument to this
function, we should just create a new function which does what we
want. Internally, that could either pass the necessary values through
the rest of the glamor API or it could do the hack which you've already
identified.

Maybe 'glamor_fd_from_back_pixmap'? given where this is used?
Suggestions welcome.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160818/6010806c/attachment.sig>


More information about the xorg-devel mailing list