[PATCH xserver] test: Remember to swap the window argument to XIQueryPointer

Julien Cristau jcristau at debian.org
Wed Aug 17 15:19:50 UTC 2016


On Wed, Aug 17, 2016 at 10:43:27 -0400, Adam Jackson wrote:

> Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer
> manually emitted its own error before (bogusly) returning Success to the
> main loop. Since these tests only look at the return value of the
> dispatch function we'd think things succeeded even when we'd generated
> an error.
> 
> With that fixed, the test code's failure to swap the window id would
> make dixLookupWindow (rightly) throw BadWindow.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  test/xi2/protocol-xiquerypointer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Reviewed-by: Julien Cristau <jcristau at debian.org>

Cheers,
Julien


More information about the xorg-devel mailing list