[PATCH v5 01/13] xf86: Add PRIME flipping functions to Screen

[Dave Airlie]

On 13 April 2016 at 14:17, Alex Goins <agoins at nvidia.com> wrote:
> Adds typedefs for (*RRStartFlippingPixmapTrackingProcPtr),
> (*RREnableSharedPixmapFlippingProcPtr),
> and (*RRDisableSharedPixmapFlippingProcPtr) in randrstr.h.
>
> Adds typedefs for (*PresentSharedPixmapProcPtr),
> (*SharedPixmapNotifyDamageProcPtr),
> (*RequestSharedPixmapNotifyDamageProcPtr), and
> (*StopFlippingPixmapTrackingProcPtr) in scrnintstr.h.
>
> Adds RR(Enable/Disable)SharedPixmapFlipping, and
> RRStartFlippingPixmapTracking to rrScrnPrivRec.
>
> Adds StopFlippingPixmapTracking, PresentSharedPixmap,
> SharedPixmapNotifyDamage, and RequestSharedPixmapNotifyDamage to ScreenRec.
>
> rrScrnPrivRec used for functions that use RandR-private data types, and
> ScreenRec used for the rest.
>
> RREnableSharedPixmapFlipping will allow the sink driver to setup for
> flipping between two shared pixmaps.
>
> RRDisableSharedPixmapFlipping will allow the sink driver to do teardown
> associated with flipping between two shared pixmaps.
>
> (RRStart/Stop)FlippingPixmapTracking are merely the double-buffered
> equivalents of (Start/Stop)PixmapTracking, allowing the source driver to do
> whatever setup and teardown necessary for presenting on the two shared
> pixmaps.

Why does Start take a crtc? I can't see it being used here, do you need it
for some reason in some other case, I think it should be migrated to Screen
it it doesn't need the crtc. It would also be more symmetrical.

Dave.