[PATCH libICE] Enable visibility annotations

Jon Turney jon.turney at dronecode.org.uk
Thu Apr 28 16:38:08 UTC 2016


On 28/04/2016 14:59, Emil Velikov wrote:
> Are you sure that think this is correct ? Afaict things should work,
> despite that xserver sets SYMBOL_VISIBILITY=no.
>
> Jon, any ideas why xserver disables -fvisibility=hidden ? Should we
> remove that line or there's something subtle that requires the
> behaviour ? For example: relying on symbols that are not marked as
> exported or alike.
>
> From past (ancient) experiences and reading the wiki correctly,
> combining -fivisiblity=hidden + dllimport/dllexport should work fine ?

As far as I recall, the issue was simply that if you use 
-fvisibility=hidden for a PE/COFF target, gcc will warn 'visibility 
attribute not supported in this configuration; ignored' on every single 
symbol declaration with default visibility, which is really annoying...



More information about the xorg-devel mailing list