[PATCH] uxa: fix missing includes for fstat

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 27 22:23:10 UTC 2016


On 26 April 2016 at 15:07, Stefan Dirsch <sndirsch at suse.de> wrote:
> On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
>> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
>> > From: Dominique Leuenberger <dimstar at opensuse.org>
>> >
>> > Without these headers, we can run into build errors like:
>>
>> sys/stat.h is already included. Curious.
>> -Chris
>
> I can't see it included by uxa/intel_driver.c. Build still fails for me with
>
>   -Werror=implicit-function-declaration
>
> being set. Same applies to the patch for sna/intel_driver.c.
>
Seems like you've got out of date tree in there.

commit 369ceec0e4910ba2c37736a59c55c0d6c26433bf
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Tue Feb 24 15:25:40 2015 +0000

    uxa: udev integration depends on fstat and sys/stat.h

    src/uxa/intel_driver.c: In function 'I830HandleUEvents':
    src/uxa/intel_driver.c:738:14: error: storage size of 's' isn't known
    src/uxa/intel_driver.c:746:2: error: implicit declaration of
function 'fstat' [-Werror=implicit-function-declaration]

    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
...

Regards
Emil

P.S. For xorg-devel patches please set the correct prefix $ git config
--local format.subjectPrefix "PATCH foo". With foo being the
respective project.


More information about the xorg-devel mailing list