[PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

Alan Coopersmith alan.coopersmith at oracle.com
Wed Apr 27 05:04:26 UTC 2016


On 04/26/16 07:31 AM, walter harms wrote:
>
> fix signess warning by casting
> Signed-off-by: walter harms <wharms at bfs.de>
>
>
> ---
>   src/ModMap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ModMap.c b/src/ModMap.c
> index a809aa2..4263a8b 100644
> --- a/src/ModMap.c
> +++ b/src/ModMap.c
> @@ -39,7 +39,7 @@ XGetModifierMapping(register Display *dpy)
>       XModifierKeymap *res;
>
>       LockDisplay(dpy);
> -    GetEmptyReq(GetModifierMapping, req);
> +    GetEmptyReq(GetModifierMapping, req); // Never used ?
>       (void) _XReply (dpy, (xReply *)&rep, 0, xFalse);

The request is used on the very next line, where it's sent to the
Xserver and then _XReply waits for the response.  It's just all the
behind the scenes magic of the X request buffer handling in Xlib.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list