[PATCH] Avoid 10x7 heuristic, handled by server

[Stefan Dirsch]

On Tue, Apr 26, 2016 at 03:49:12PM +0200, Julien Cristau wrote:
> On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote:
> 
> > On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote:
> > > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:
> > > 
> > > > From: Frederic Crozat <fcrozat at suse.com>
> > > > 
> > > > Remove the 10x7 heuristic, since the server has equivalent code now.
> > > > Instead, disable "acceleration" under qemu, since taking the hypercall
> > > > trap is really quite expensive and you're better off doing noaccel.
> > > > (Fedora)
> > > > ---
> > > >  src/alp_driver.c | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > What does "the 10x7 heuristic" refer to?  Maybe
> > > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=b726ffdd66d6aaf49c64f999eb2c004e1d5041fb
> > > which is an earlier version of this patch?
> > 
> > Wow! Thanks for the pointer. Honestly I never understood the comment, since
> > today I've seen the original patch the first time. ;-) LOL!
> > 
> > > (Also, authorship seems wrong, if you took this patch from Fedora, it
> > > should be attributed to ajax afaict:
> > > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/log/cirrus-1.2.0-qemu.patch
> > 
> > Ok. Since the patch we're using is obviously no longer related to Ajax'
> > original one I keep it attributed to Frederic. Unless he or you're vetoing. I
> > could add "very loosely based on Ajax' patch" though.
> > 
> The patch you're using today seems to be pretty much the same as
> http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=daccd1c8174623500eddfa297d8ea76a86d3c5d9

Indeed. Apparently Frederic didn't make the changes himself, but instead
updated the patch from Fedora. This is again news for me. Things are getting
more and more embarassing. Sigh.

Be assured I only want to be a good citizen and bring "our" patches upstream.
It hasn't been my intention to attribute the patch to the wrong person. I've
resent the patch to the list making myself the author and added to the commit
message, that the patch is based on the one by Ajax. And added the reference
to it. I'm not sure whether this is any better. Feel free to comment.

Thanks,
Stefan

Public Key available
------------------------------------------------------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0            Maxfeldstraße 5
FAX: 0911-740 53 479          D-90409 Nürnberg
http://www.suse.de            Germany 
---------------------------------------------------------------
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---------------------------------------------------------------