[PATCH] Avoid 10x7 heuristic, handled by server

Julien Cristau jcristau at debian.org
Tue Apr 26 10:58:55 UTC 2016


On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:

> From: Frederic Crozat <fcrozat at suse.com>
> 
> Remove the 10x7 heuristic, since the server has equivalent code now.
> Instead, disable "acceleration" under qemu, since taking the hypercall
> trap is really quite expensive and you're better off doing noaccel.
> (Fedora)
> ---
>  src/alp_driver.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
What does "the 10x7 heuristic" refer to?  Maybe
http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=b726ffdd66d6aaf49c64f999eb2c004e1d5041fb
which is an earlier version of this patch?

(Also, authorship seems wrong, if you took this patch from Fedora, it
should be attributed to ajax afaict:
http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/log/cirrus-1.2.0-qemu.patch
)

Cheers,
Julien

> diff --git a/src/alp_driver.c b/src/alp_driver.c
> index bd5e52f..da31321 100644
> --- a/src/alp_driver.c
> +++ b/src/alp_driver.c
> @@ -774,6 +774,13 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
>       else
>   	xf86SetDDCproperties(pScrn,xf86PrintEDID(
>  		 xf86DoEDID_DDC2(XF86_SCRN_ARG(pScrn),pCir->I2CPtr1)));
> +
> +#ifdef XSERVER_LIBPCIACCESS
> +     if (!pScrn->monitor->DDC &&
> +	((pCir->PciInfo->subvendor_id & 0xffff) == 0x1af4)) {
> +	pCir->NoAccel = TRUE;
> +     }
> +#endif
>   
>       /* Probe the possible LCD display */
>       AlpProbeLCD(pScrn);
> -- 
> 2.6.2
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: https://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list