[PATCH xserver v2 7/9] xfree86: Remove a never-hit diagnostic message

Adam Jackson ajax at nwnk.net
Fri Apr 15 16:17:04 UTC 2016


On Mon, 2016-04-11 at 14:25 +0200, walter harms wrote:
> edidSize() checks for if (DDC->ver.version != 1) (see 6/9)
> so this is bogus either ?

I suppose the check in edidSize isn't strictly necessary. DDC2_Read
will always return a validly-sized block, so the math we do here will
be correct. Its content might not be valid as EDID, but it will at
least self-describe its length as if it were.

To Michel's question: dixChangeWindowProperty does behave correctly
when given a zero-length property, it truncates the property's value to
empty.

- ajax


More information about the xorg-devel mailing list