Pointer acceleration update

Simon Thum simon.thum at gmx.de
Mon Apr 11 16:14:19 UTC 2016


Hi all,

between jobs I found some time to give some TLC to pointer acceleration, 
mostly it's about minor issues and cleanup that accumulated over time.

The most interesting one is the removal of the "lightweight" scheme and 
some of scheme switching, and the fix to profile 4 (which is in effect 
by default). The fixes to softening should restore lost subpixel precision.

To make sure that it's not just one well-tested profile which is faulty, 
I also added a unit test for the profiles whose output can be plotted 
with gnuplot. So if you are really curious, you can adjust the test 
parameters, e.g. to those you use, and have the profiles plotted. If you 
are less curious, look at the graphs I attached (I hope it's OK to spend 
160k on this).

The graphs use the defaults (acceleration = 2.0; threshold = 4.0) with 
adaptive deceleration = 1 (default) and 3. The "buggy" graph just 
displays the faulty previous profile 4 for reference.

Aside from the unit test, I admittedly have not given them too much 
testing, but they're mostly trivial except for number 5 (lightweight 
scheme removal) which is independent from the rest. I will use them 
myself as soon as an unrelated xcb problem is fixed, but in general I 
think they are safe.

Safe, that is, except for the API and ABI changes produced by the 
switching removal. If desired an equivalent without ABI breaks can be 
made, but will leave unused stuff around. Since a release has just been 
issued I opted for the break.

Cheers,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dix-ptraccel-Disable-softening-by-default.patch
Type: text/x-patch
Size: 2180 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dix-ptraccel-Fix-softening.patch
Type: text/x-patch
Size: 2798 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dix-ptraccel-Backport-libinput-profile-fix.patch
Type: text/x-patch
Size: 2172 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dix-ptraccel-Fix-memory-leak-in-InitPredictableAccel.patch
Type: text/x-patch
Size: 1502 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-dix-ptraccel-Remove-lightweight-floating-pointless-a.patch
Type: text/x-patch
Size: 10827 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-dix-ptraccel-Remove-float-literals.patch
Type: text/x-patch
Size: 4442 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-dix-ptraccel-Fix-comments.patch
Type: text/x-patch
Size: 7378 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-tests-Add-test-for-sampling-profiles.patch
Type: text/x-patch
Size: 5223 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buggy-profile.png
Type: image/png
Size: 23097 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-profiles-adapt-decel.png
Type: image/png
Size: 67389 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-profiles-default.png
Type: image/png
Size: 57088 bytes
Desc: not available
URL: <https://lists.x.org/archives/xorg-devel/attachments/20160411/09c2a0a0/attachment-0005.png>


More information about the xorg-devel mailing list