[PATCH] rootless: Fix bogus handling of broken root clip

[Keith Packard]

Adam Jackson <ajax at redhat.com> writes:

> gcc quite correctly complains about this:
>
>     In file included from ../../include/scrnintstr.h:51:0,
>                      from rootlessValTree.c:98:
>     In function 'RegionUninit.isra.1',
>         inlined from 'RegionEmpty' at ../../include/regionstr.h:194:5,
>         inlined from 'RootlessMiValidateTree' at rootlessValTree.c:490:9:
>     ../../include/regionstr.h:166:9: warning: attempt to free a non-heap object 'RegionBrokenData' [-Wfree-nonheap-object]
>              free((_pReg)->data);
>
> So that'd crash if you ever got there.  RegionNull will do almost the
> same thing only without the free(), so let's do that instead; it might
> still not be an entirely sane way to recover, but it at least won't
> crash.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150921/c1619d17/attachment.sig>