[PATCH 2/3] Input: Add KeyFocusIn internal event

[Daniel Stone]

Hi,

On 28 November 2014 at 06:02, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> On Mon, Nov 24, 2014 at 10:17:33PM +0000, Daniel Stone wrote:
>> diff --git a/xkb/xkbActions.c b/xkb/xkbActions.c
>> index c6cbf56..c075115 100644
>> --- a/xkb/xkbActions.c
>> +++ b/xkb/xkbActions.c
>> @@ -1144,9 +1144,10 @@ _XkbEnsureStateChange(XkbSrvInfoPtr xkbi)
>>  }
>>
>>  static void
>> -_XkbApplyState(DeviceIntPtr dev, Bool genStateNotify, int evtype, int key)
>> +_XkbApplyState(DeviceIntPtr dev, Bool genStateNotify, int evtype_int, int key)
>
> .. Bool genStateNotify, enum EventType evtype, int key)
>
> we have an enum, use it, it's much more expressive than "int evtype_int".

Funnily enough, we can't, because of XkbPushLockedStateToSlaves which
you noted below: as of commit 45fb3a934d, we call
XkbPushLockedStateToSlaves with an event type of 0 (doesn't map to
anything in EventType) and a keycode of 0 as well. Ho hum. (It does
look like that commit would also cause duplicate state notifications
for every action handled, but that's neither here nor there.)

Cheers,
Daniel