[PATCH:xf86-video-siliconmotion 1/2] Fix endian detection on NetBSD.

Alan Coopersmith alan.coopersmith at oracle.com
Mon Sep 14 10:22:06 PDT 2015


On 09/14/15 09:39 AM, Thomas Klausner wrote:
> NetBSD provides BYTE_ENDIAN, but this driver looks for __BYTE_ENDIAN.
> ---
>   src/smi.h | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/src/smi.h b/src/smi.h
> index 5e44892..f3227e0 100644
> --- a/src/smi.h
> +++ b/src/smi.h
> @@ -67,6 +67,12 @@ authorization from the XFree86 Project and Silicon Motion.
>   /*			D E F I N I T I O N S				      */
>   /******************************************************************************/
>
> +#ifdef __NetBSD__
> +#define __BYTE_ORDER BYTE_ORDER
> +#define __LITTLE_ENDIAN LITTLE_ENDIAN
> +#define __BIG_ENDIAN BIG_ENDIAN
> +#endif
> +

Should it be including <X11/Xarch.h> instead?   (Actual question - I don't know
the answer, just know that's an already existing definition of those symbols.)

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list