[PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

Keith Packard keithp at keithp.com
Wed Sep 9 18:41:25 PDT 2015


Emil Velikov <emil.l.velikov at gmail.com> writes:

> From a very quick look, only fontstruct.h seems to be used. If truly
> so, one can rework it (rename or fold into libxfont2.h, rename the
> symbols ?) and drop the rest from libXfontinclude_HEADERS.

fontstruct.h comes from proto/fontsproto

However, fontutil.h does come from libXfont, and has only a small
handful of functions used by the server. Moving those to libXfont2.h
would be simple.

None of the other headers from libXfont are used in the X server, but
many are used in the other font utilities (bdftopcf et al).

> Additionally it'll be great to sanitise the list of exported symbols,
> as things might go nasty as we end up with both libXfont.so
> libXfont2.so opened at the same time.

libXfont is used only by the X server, the font server, and the
various font utilities, so I think it's safe to assume that no
application will use both versions.

> As previously this just a suggestion, so feel free to take it or leave it.

I hadn't changed the common header files, but you are most correct in
asserting that we cannot install them from both versions of the library;
that would cause packaging problems, even if the contents of the files
were identical.

So, two simple solutions:

 1) Rename the install target to X11/fonts2/
 2) Merge all of the library API definitions into the new libxfont2.h

I'm tempted to select option 2) as I'm not a huge fans of file names
differing only in their directory component, but 1) would be simpler.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150909/a27e2c0d/attachment.sig>


More information about the xorg-devel mailing list