[PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

Matt Turner mattst88 at gmail.com
Wed Sep 2 16:01:53 PDT 2015


On Wed, Sep 2, 2015 at 2:30 PM, Keith Packard <keithp at keithp.com> wrote:
> This eliminates the weak symbol adventures and makes all of the calls
> back to the X server or Font server go through a table of functions
> instead, clarifying the required API.
>
> As this is a rather major change to the API for the library, it now
> installs itself as libXfont2 instead of libXfont, and the package
> config file is now xfont2.pc.
>
> All of the installed headers remain the same as the original library;
> there's now a new include file, libxfont2.h, which defines the X
> server and Font server interfaces.
>
> This moves util/atom.c to stubs/atom.c and reformats that file, hence
> the diff being larger than it would otherwise be.
>
> v2: Rename to libXfont2 instead of libXfont_2 as suggested by Emil Velikov
>     Fix whitespace in stubs/atom.c, which was moved from util/
>
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---

Does this change break the existing libXfont ABI for things other than
the xserver? Diffing the nm -DCg output, it looks like we're removing
some weak symbols, and __GetServerClient which doesn't look like it's
part of the API.

If the ABI is still compatible with libXfont-1.5.1, do we need to
change the soname?


More information about the xorg-devel mailing list