[PATCH libXfont] Eliminate calls back to X server or font server functions by name

Keith Packard keithp at keithp.com
Wed Sep 2 13:09:46 PDT 2015


Matt Turner <mattst88 at gmail.com> writes:

>> +#include       <X11/fonts/libxfont.h>
>
> I don't know where this header is supposed to be (maybe it's supposed
> to be libxfont_2.h?), but it's not there and causes a build failure.
> Simply removing the #include lets it compile without warnings.

Yeah, I refactored the includes and now this file just includes
libxfontint.h, which includes libxfont_2.h, which used to be called
libxfont.h until just before I pushed the patch.

> Space before tab on this line

This file was moved from util/, and I didn't clean up the whitespace
after doing that. I've done so now.

Thanks much for your review; this is not the final API for this library,
as the real goal is to eliminate the select masks everywhere, this was
just some API sanitation before I merged the rest of the work.

-- 
-keith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20150902/721c77f1/attachment.sig>


More information about the xorg-devel mailing list