[PATCH] vidmode: Drop the unused event code

Adam Jackson ajax at redhat.com
Fri Oct 30 07:06:59 PDT 2015

On Thu, 2015-10-29 at 23:19 +0000, Emil Velikov wrote:

> Small question - some places in xserver have a if 0 guard (while
> others do ifdef DEBUG) for the DEBUG_P-like macros. Is that
> intentional - or it's mostly a matter of personal preference ?

I suspect more a matter of preference, but I don't think it's anything
that's been done with a consistent vision really. --enable-debug gives
you a fairly arbitrary set of additional printfs, it would be nice if
that were made more consistent and considered.

The DEBUG_P stuff in xf86vmode.c in particular is distasteful. A lot of
that kind of code in xserver I thnk is an artifact of the old xfree86
loader and associated difficulty in using gdb. I'd rather see debug
code that dumps interesting bits of internal state or applies
additional consistency checks, and not just a "got here" message that a
breakpoint would tell you just as well.

- ajax

More information about the xorg-devel mailing list