[PATCH] vidmode: Drop the unused event code

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 29 15:56:20 PDT 2015

On 29 October 2015 at 14:08, Adam Jackson <ajax at redhat.com> wrote:
> As the code says, this is "far from complete".  So far, in fact, that
> it's been basically untouched for twenty years (XFree86 3.1!).  As far
> as I can tell it was never enabled in any XFree86 build, and certainly
> has never been enabled since Xorg 7.0.
> Also, K&R.
> Signed-off-by: Adam Jackson <ajax at redhat.com>

I second your git archaeological discovery - upstream has ever set

While here one can also nuke the if 0 guarded XF86VidModeReqCode
hunks. Regardless this patch is
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Small question - some places in xserver have a if 0 guard (while
others do ifdef DEBUG) for the DEBUG_P-like macros. Is that
intentional - or it's mostly a matter of personal preference ?


More information about the xorg-devel mailing list