[PATCH xserver] xwayland: Add Xfree86-VidModeExtension to Xwayland

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 29 15:38:07 PDT 2015

On 29 October 2015 at 14:10, Adam Jackson <ajax at nwnk.net> wrote:
> On Thu, 2015-10-29 at 09:50 +0000, Emil Velikov wrote:
>> On 29 October 2015 at 09:37, Olivier Fourdan <ofourdan at redhat.com> wrote:
>> > Hi Krzysztof,
>> >
>> > Quick question, as I haven't heard back from you, do you plan to follow up
>> > on these patches or should I fix them?
>> >
>> While there, can someone confirm if the two extra files aren't just a
>> copy/pasta from existing xserver/other code base ? If so shouldn't one
>> reuse the current files - copying them around might not be the best of
>> ideas.
> They are mostly copypasta, yes.  Reusing them directly is a little
> difficult because the current implementation includes xfree86 headers,
> so "reusing the current files" would be:
>From a quick look it seemed like a straight copy/paste job. I guess
one could have mentioned the diffs wrt the original ;-)

> 1) detach hw/xfree86/common/xf86vmode.c from xfree86 headers
> 2) move it up to Xext/, (probably as a separate module and not glommed
> into libXext.la)
> 3) add backend to hw/xwayland
> Alternatively, we could do a generic translation layer from vidmode to
> randr, but that's probably a bit more involved.
I'll take a look at option 1 over the next few days, although if you
have some tips on the vidmode > randr layer that'll be appreciated.


More information about the xorg-devel mailing list