[PATCH] present: Execute right away if target_msc equals current_msc

Michel Dänzer michel at daenzer.net
Wed Oct 28 19:53:25 PDT 2015


On 28.10.2015 19:39, Jammy Zhou wrote:
> It is according to the protocol:
> 
> "If 'options' contains PresentOptionAsync, and the 'target-msc'
> is less than or equal to the current msc for 'window', then
> the operation will be performed as soon as possible, not
> necessarily waiting for the next vertical blank interval."
> 
> Signed-off-by: Jammy Zhou <Jammy.Zhou at amd.com>
> ---
>  present/present.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/present/present.c b/present/present.c
> index beb4ff0..5900c22 100644
> --- a/present/present.c
> +++ b/present/present.c
> @@ -871,7 +871,7 @@ present_pixmap(WindowPtr window,
>  
>      xorg_list_add(&vblank->event_queue, &present_exec_queue);
>      vblank->queued = TRUE;
> -    if ((pixmap && target_msc >= crtc_msc) || (!pixmap && target_msc > crtc_msc)) {
> +    if (target_msc > crtc_msc) {
>          ret = present_queue_vblank(screen, target_crtc, vblank->event_id, target_msc);
>          if (ret == Success)
>              return Success;
> 

Looks good to me, but Cc'ing Axel Davy, who made the last change to this
code.

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the xorg-devel mailing list