[PATCH v2] linux: Do not call FatalError from xf86CloseConsole

Adam Jackson ajax at nwnk.net
Wed Oct 21 07:41:33 PDT 2015

On Wed, 2015-10-21 at 11:36 +0200, Hans de Goede wrote:
> FatalError ends up calling xf86CloseConsole itself, so calling FatalError
> from within xf86CloseConsole is not a good idea.
> Make switch_to log errors using xf86Msg(X_WARNING, ...) and return success
> (or failure).
> This makes switch_to match the other error checking done in xf86CloseConsole
> which all logs warnings and continues.
> Add checking of the return value in xf86OpenConsole and call
> FatalError there when switch_to fails, to preserve the error-handling
> behavior of xf86OpenConsole.
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1269210
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

remote: I: patch #62451 updated using rev 2092f12a243b9f7682f542b593b77c96d455ec89.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   ee06f67..2092f12  master -> master

- ajax

More information about the xorg-devel mailing list