[PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede hdegoede at redhat.com
Mon Oct 19 05:40:46 PDT 2015


On 19-10-15 14:00, Samuel Thibault wrote:
> Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit :
>>> If you're doing this with certain platforms in mind, maybe
>>> we need to only not check for libdrm on those platforms ?
>> Does it make sense at all to use the wrapper on platforms without drm?
> We need some setuid wrapper, yes, and we'd like to be able to configure
> whether all users can run it, or only users which are loggued on the
> console.

We == hurd developers / users here, right ?

I'm not against taking a patch to make this work for you, I'm just
not convinced that unconditionally dropping the libdrm check is a good
idea. I agree that most people who need the wrapper should always be
building with libdrm anyways, but I would like to keep enforcing that.

To me hurd is the exception here. So maybe change the patch to drop
the configure libdrm check for hurd ? If that is done I'm fine with the
#ifdef LIBDRM in the wrapper itself.



More information about the xorg-devel mailing list