[PATCH] xorg-wrapper: fix build without libdrm

Mark Kettenis mark.kettenis at xs4all.nl
Mon Oct 19 03:26:27 PDT 2015

> From: Hans de Goede <hdegoede at redhat.com>
> Date: Mon, 19 Oct 2015 11:14:21 +0200
> Hi,
> On 19-10-15 11:03, Samuel Thibault wrote:
> > Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit :
> >> In which case would you want to build without libdrm anyways ? Can you
> >> explain the use-case for this patch ?
> >
> > Systems with no drm support, simply :)
> Actually I do not think it is that simple, e.g. IIRC the openbsd
> people have their own solution for non requiring root rights.

Right.  Our privsep'ed Xorg needs to be suid root in order to be able
to drop priviliges.  So we don't use the wrapper.

> Also with your patch people may accidentally end up build the
> root-wrapper on Linux without libdrm resulting in a root-wrapper
> which will just always launch the xserver as root.
> If you're doing this with certain platforms in mind, maybe
> we need to only not check for libdrm on those platforms ?

Does it make sense at all to use the wrapper on platforms without drm?
Seems to me that if there is no runtime decision to be made, you
should just install Xorg either setuid or non-suid depending on the
needs to of the platform.

More information about the xorg-devel mailing list