[PATCH] xorg-wrapper: fix build without libdrm

[Samuel Thibault]

Hans de Goede, le Mon 19 Oct 2015 11:14:21 +0200, a écrit :
> On 19-10-15 11:03, Samuel Thibault wrote:
> >Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit :
> >>In which case would you want to build without libdrm anyways ? Can you
> >>explain the use-case for this patch ?
> >
> >Systems with no drm support, simply :)
> 
> Actually I do not think it is that simple, e.g. IIRC the openbsd
> people have their own solution for non requiring root rights.

I don't see where this happens on the xorg wrapper.

> Also with your patch people may accidentally end up build the
> root-wrapper on Linux without libdrm resulting in a root-wrapper
> which will just always launch the xserver as root.

Which will be needed anyway if they want to see the X server working at
all on Linux.

> If you're doing this with certain platforms in mind, maybe
> we need to only not check for libdrm on those platforms ?

You mean hardcoding the set of such platforms inside xorg-wrapper.c?

Well, that'd be at least cygwin (though the wrapper is probably useless
there), darwin, hurd.

Samuel